Skip to content

Minor fixes pk 2

Philipp Kutin requested to merge helixhorned/eduke32:minor-fixes-pk-2 into master

Continuing to address minor things brought to my attention by the compiler or sanitizers.

I didn't address all that I encountered. With this setup,

pk-temporary-san-setup-armv7l.diff

I also observed:

source/build/src/lz4.c:893:29: runtime error: applying non-zero offset 65535 to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior source/build/src/lz4.c:893:29 in 
source/build/src/lz4.c:1095:24: runtime error: applying non-zero offset 65535 to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior source/build/src/lz4.c:1095:24 in

source/build/src/engine.cpp:3527:28: runtime error: -2.55335e+10 is outside the range of representable values of type 'unsigned long long'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior source/build/src/engine.cpp:3527:28 in
source/build/src/engine.cpp:3606:30: runtime error: division by zero
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior source/build/src/engine.cpp:3606:30 in 
source/build/src/engine.cpp:3607:30: runtime error: division by zero
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior source/build/src/engine.cpp:3607:30 in

source/duke3d/src/player.cpp:3120:94: runtime error: division by zero
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior source/duke3d/src/player.cpp:3120:94 in

(The lz4 one should be easy, assuming it's still present upstream.)

Merge request reports