Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • EDuke32 EDuke32
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 109
    • Issues 109
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Richard Gobeille
  • EDuke32EDuke32
  • Merge requests
  • !250

Duke3D: Fix flicker in automatic view angle

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Ricardo Garcia requested to merge rg3/eduke32:fix-slope-flicker-mr into master Feb 01, 2023
  • Overview 3
  • Commits 1
  • Changes 2

This MR fixes two small issues when an automatic view angle is calculated, typically when going up or down a slope.

  • Sometimes the game calculates an excessive slope difference between the current view angle and the slope angle, leading to a vertical flicker in the image momentarily. This is specially noticeable in E1L6, for example, when going up the slope to the force field control tower, which uses horizontal sprites to cover gaps.

  • To make movement smoother, apply a small delay (100ms) when starting to adjust the view angle automatically.

Fixes #265

Video showcasing the issue: https://rg3.name/pub/duke3d-slope-flicker/slope-flicker.mkv

After applying this fix: https://rg3.name/pub/duke3d-slope-flicker/slope-flicker-fixed.mkv

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-slope-flicker-mr