Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • EDuke32 EDuke32
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 109
    • Issues 109
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Richard Gobeille
  • EDuke32EDuke32
  • Merge requests
  • !123

Draft: Engine: enable 3 digit pal sequence in OSD and Duke3D game text

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Dino Bollinger requested to merge dibollinger/eduke32:3palseq into master Jul 25, 2021
  • Overview 3
  • Commits 1
  • Changes 8

Palettes may be defined from 0 to 251, but in OSD and Duke3D, the escape sequence "^#" only accepts two digits currently.

In the Build engine code, some instances where this is parsed already uses 3 digits. With this MR, all cases where the pal sequence is parsed now uses three digits, and existing engine strings have been adjusted accordingly to prevent swallowing characters or displaying the wrong color.

There is a low potential for breaking some mod quotes that used colored text, if these quotes happen to continue with another digit. Highly unlikely however.

Edited Aug 22, 2021 by Dino Bollinger
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3palseq