So, if I understand your suggestion correctly, would the solution be to just add
if(strlen(fn) < 1)
{
//Probably some warning message here as well
return -1;
}
at the top of findfrompath
?
Filip Homolka (1585e73f) at 19 Sep 01:20
engine: fix polymost masked wall regression introduced in fd598dfe...
... and 554 more commits
So, an interesting update to this issue. It was caused by Pipewire. Previously, I have installed Pipewire, because it didn't have the crackling issues that Pulseaudio has. But, in the meantime, Pulseaudio fixed it, and I have recently re-installed my OS, going back to Pulseaudio.
I made a secondary install, with the only difference being replacing Pulseaudio with Pipewire - the game audio does not work, and mapster fails to quit.
So, while it is 'solved' for myself, the problem becomes shifted to: "Audio issues if the user is running Pipewire"
Filip Homolka (dd6a7f74) at 20 Sep 09:04
engine: reset rotatesprite lerp value when interpolation should not...
... and 132 more commits
Indeed, this is quite a happy resolution of this problem
The fact is that Polymer is unfinished, very cool, but unfinished. And whenever someone new joins the community, starts using the sourceport, we tell them not to use it, as it's unfinished.
Another quirk is that it causes issues with mods. Of course mods using custom builds can remove it, but some don't. And because we all know that users read the READMEs it is inevitable that they run incompatible mods with Polymer, and then go complain to the mod-maker.
The point is: polymer is, at least at this time, more of a nuisance than a useful feature, so I'm proposing that it's disabled by default. At least, until it's finished or reworked.
The title is more or less how it goes, the issue can be reproduced by running mapster32 on linux, then quitting. Mapster never quits, just hangs, until the process is forcefully terminated. Poking at the issue reveals that the issue happens in multivoc.cpp
MV_Shutdown
function calls SoundDriver_PCM_Shutdown
function, and never progresses from there. SoundDriver_PCM_Shutdown
, defined in drivers.cpp
, contains one line: SoundDrivers[ASS_PCMSoundDriver].PCM_Shutdown();
, and this is where it hangs until killed.
There is a potential for this to be specific to few machines, however, Mapster32 is the only program that I have experienced this with. Windows does not have this issue.
Filip Homolka (2b4fa55f) at 09 Jul 13:34
SW: Prevent invalid array access in drawoverheadmap()
... and 15 more commits
The fact is that Polymer is unfinished, very cool, but unfinished. And whenever someone new joins the community, starts using the sourceport, we tell them not to use it, as it's unfinished.
Another quirk is that it causes issues with mods. Of course mods using custom builds can remove it, but some don't. And because we all know that users read the READMEs it is inevitable that they run incompatible mods with Polymer, and then go complain to the mod-maker.
The point is: polymer is, at least at this time, more of a nuisance than a useful feature, so I'm proposing that it's disabled by default. At least, until it's finished or reworked.
Filip Homolka (065284b2) at 30 Jun 14:37
SW: Fix Wangulator crashing on launch
... and 7 more commits
Filip Homolka (ad8def49) at 29 Jun 14:07
Duke3d: animate menus independently from totalclock
... and 55 more commits
Filip Homolka (39e8f185) at 26 Jun 04:44
SW: Fix commandline parameter inconsistencies and errors.
Filip Homolka (45e167f6) at 13 Jun 00:59
Duke3d: Fix typo in G_CheckActivatorMotion()
Filip Homolka (fe837e07) at 09 Jun 02:06
Disable the version check, at least for now. It's needlessly sendin...
Filip Homolka (1c8610d4) at 09 Jun 02:01
Filip Homolka (1c8610d4) at 09 Jun 02:00
Disable the version check, at least for now. It's needlessly sendin...
Filip Homolka (189ed293) at 09 Jun 01:58
Duke3d: fix warnings in EDUKE32_STANDALONE build
... and 8 more commits
Filip Homolka (bcc1cb0d) at 05 Jun 01:57
engine: update to SDL 2af3f64e on Windows
... and 62 more commits
Filip Homolka (c38987bb) at 31 Mar 13:16
Move S_DefineSound, S_DefineMusic, and S_DefineAudioIfSupported out...
... and 4 more commits